Improve runtests and CI pipeline #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 17 17
Lines 1619 1619
=======================================
Hits 1453 1453
Misses 166 166 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the summary changes for this PR, which I think is quite necessary to do before getting more and more people involved to contribute to this package.
testsetsinto individual files, which would be better for everyone to cooperate in the futureSafeTestsetsto make alltestsetsbe really independent with each other (I found some small bugs in the original runtests, like one is using the variables in anothertestset)group: Core, to specify that we are testing core functionalities for our packages (this is just in case that we might have extensions in the future)I'm making these changes based on my habits, of course it doesn't necessarily to do it in my way.